Repository navigation
docs(tasks): an Atom summary is escaped twice - #17
Merged
adammharris merged 1 commit intoNov 9, 2026
Merged
Conversation
adammharris
deleted the
agent/backlog-file-an-atom-summary-escapes-twice
branch
November 9, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files a task for a defect in the Atom feed. This PR adds a document and no code.
What's wrong.
generate_atom_feed(plates-render/src/page.rs) builds each entry's<summary>by running the rendered HTML throughstrip_html_truncateand thenxml_escape. Stripping the tags leaves the entities the renderer wrote (&,<,>), andxml_escapeescapes their&a second time. A body ofTom & Jerry <3renders to<p>Tom & Jerry <3</p>, and its entry ends up with<summary>Tom &amp; Jerry &lt;3</summary>, which a feed reader shows asTom & Jerry <3.<content>(CDATA) and the RSS feed are not affected.The task also notes that
strip_html_truncatemeasures its 280-character limit in bytes, not characters.How it was found. I called
generate_atom_feedandrender_bodyfrom a throwaway test onmainat 134b3b0. That test is not part of this PR.Checks.
prov checkreports no findings. The change is documents only, so nothing builds.The fix is left for its own branch,
agent/backlog-an-atom-summary-escapes-twice.