Repository navigation
ci: run prov check over prov's own workspace - #18
Merged
Merged
Conversation
8247d29 rewrote the self-hosted-kernel ORGANIZATION.md example from `;;;` to `---json` outside prov, so its sidecar kept the old content_hash and `prov check` at the root reported a fixity mismatch. The rewrite is the text meant, so the sidecar is restamped. Nothing in CI read docs/, which is how it landed. A `prov-check` job in .config/ship.figl now builds prov-cli and runs its `prov check` over the repository, so the next out-of-band edit to a covered file fails CI. Closes docs/tasks/own-docs-fail-prov-check.md, shelved under Closed tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
8247d29(build(deps)!: move to fig 7 and twig 6) rewrotedocs/proposals/self-hosted-kernel/examples/ORGANIZATION.mdfrom;;;JSON to---jsonfrontmatter outside prov. That rewrite is deliberate (the same commit retired;;;and updated the example's prose to match), soprov stamprecords the current bytes. The newcontent_hash(sha256:771ed060…) matches thesha256sumin the task's repro.prov-check, in.config/ship.figl. It builds prov-cli and runstarget/debug/prov checkat the root.ci.ymlgets its jobs fromship ci --matrix, so the job shows up asCI / prov checkwith no workflow edit. Next time a covered file is edited outside prov, CI fails instead of the bad checksum landing on main.Why
On
main,prov checkreports a fixity mismatch on that sidecar and exits 1. None of the existing CI jobs readsdocs/, which is how it got merged.Task
Closes
docs/tasks/own-docs-fail-prov-check.md: statusdone, shelved intodocs/tasks/closed/withprov mv --in.Verification
ship ci prov-checkfailed on this branch with the mismatch from the task.prov check(the freshly built binary) printsok: no findings.ship cirun locally: all 7 jobs passed (fmt, clippy-D warnings, test, guide transcripts, prov check, package isolation, MSRV).