Repository navigation
fix(fixity): size the hashing budget to the threads that drain it - #21
Merged
Merged
Conversation
A fixed 256 MB of read-but-unhashed bytes is right for a laptop and too much for a two-core NAS, whose hash threads also lose the CPU to the filesystem and everything else it runs. Covering an 80,857-file photo share there peaked at 407 MB on 2 GB of RAM. The budget is now 32 MiB per rayon thread, still capped at 256 MiB. With two threads and 60 MB files read from cache, peak memory falls from 294 MB to 122 MB at the same speed; eight threads are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fixed 256 MB of read-but-unhashed bytes is right for a laptop and too
much for a two-core NAS, whose hash threads also lose the CPU to the
filesystem and everything else it runs. Covering an 80,857-file photo
share there peaked at 407 MB on 2 GB of RAM.
The budget is now 32 MiB per rayon thread, still capped at 256 MiB. With
two threads and 60 MB files read from cache, peak memory falls from
294 MB to 122 MB at the same speed; eight threads are unchanged.