Repository navigation
docs(tasks): prov's tests leave their fixtures in the temp directory - #25
Merged
adammharris merged 1 commit intoNov 5, 2026
Merged
Conversation
adammharris
deleted the
agent/backlog-file-tests-leave-their-fixtures-in-temp
branch
November 5, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files a task. There is no code change.
What
A passing
cargo test --workspaceleaves 741 entries (34 MB, 5,318 files) in the temp directory, and each run adds more.prov_testkit::scratchbuilds its path from the process id, so it can only remove a stale directory from its own process. Its comment says the path is stable across runs and that stale directories are removed; the pid rules out both. Nothing removes the directory when a test ends. 29 other files calltemp_dir()by hand, mostly to the same pattern.This matters most where the temp directory is a tmpfs, because the leftovers then hold memory until reboot.
The new task,
docs/tasks/tests-leave-their-fixtures-in-temp.md, has the repro, the cause, a suggested starting point and a done-when. The fix is left for whoever takes it.Verified
cargo test --workspaceon1f882e0withTMPDIRset to an empty directory: 1,238 passed, 0 failed, 741 entries left behind.cargo test -p prov-viewstwice into oneTMPDIR: 10 entries, then 20.prov check, with a build of this branch, reports no findings.ship ciwas not run.