Repository navigation
feat(config_schema): govern actors, a choice of free or declared - #1
Merged
Merged
Conversation
prov writes `actors` since it learned declared people, and a config schema that does not govern a key prov writes leaves it as free text. Takes the prov that reads it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
adammharris
added a commit
that referenced
this pull request
Oct 7, 2026
feat(config_schema): govern `actors`, a choice of free or declared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: prov now writes an
actors:key (freeordeclared, from prov #9), but provui's config schema did not govern it. A settings editor showed it as free text, and diaryx'severy_key_prov_writes_is_governedtest fails as soon as diaryx takes current prov.After:
actorsis a picker with two options. "However they are written" isfree, and "By a link to their page" isdeclared. It sits next toconfirmations.How: one
choicerule incrates/provui-core/src/config_schema.rs, a test that the rule offers exactly those two values, and a prov bump inCargo.lockto the commit that reads the key. fmt, clippy and the workspace tests pass locally.This unblocks diaryx #121, which bumps prov and will bump provui once this merges.
🤖 Generated with Claude Code