Repository navigation
Wait for the legacy relay to start before stopping it in tests - #66
Merged
Merged
Conversation
Right after spawn, /proc/<pid>/cmdline can still be empty while the kernel finishes exec, so stopServices rightly refused to recognise the process as ours. On a busy CI runner this failed the release run for #65.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release run for #65 failed in
service.test.js > stopServices still stops what an older release recorded without start tokens.Right after
spawn,/proc/<pid>/cmdlinecan still be empty while the kernel finishesexec. An empty command line doesn't match our entry points, sostopServices(correctly) left the process alone. The test now waits for the child to printreadybefore it callsstopServices.This is a test-only change.