Repository navigation
test(spec): two union cases in the shared breaking-change vectors - #34
Merged
Merged
Conversation
The last commit of the vectors pull request (#26) was pushed after it merged, so main kept 73 cases while sdk-node, sdk-go, sdk-java, sdk-php and sdk-dotnet copied the 75-case file from its branch. This lands that commit: the cases union-required-field-no-longer-required and union-variant-numbered-with-its-null-variant, the generator entries and the detector change they need. openapi/breaking-vectors.json now has the same bytes as the other repositories (SHA-256 5c9a66000f9743f9...). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Codex review ( 💡 Code reviewReviewed commit: No actionable findings in commit Verdict: APPROVE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
openapi/breaking-vectors.jsonis generated here and copied byte for byte into the other six server SDKs (docs/DESIGN.mdsection 3.1). The last commit of the pull request that introduced it (#26) was pushed nine minutes after #26 merged, somainkept 73 cases while sdk-node, sdk-go, sdk-java, sdk-php and sdk-dotnet copied the 75-case file from the branch. The source repository is now the one that differs.Solution
Land that commit (3c361f6 from the #26 branch) unchanged:
union-required-field-no-longer-requiredandunion-variant-numbered-with-its-null-variant;codegen/breaking_vectors.py, the detector change incodegen/spec_sync.pythey need, and tests.openapi/breaking-vectors.jsonnow has the same bytes as the other repositories (SHA-256 starts5c9a66000f9743f9). Committed astest(spec), so it releases nothing.Verification
uv run pytest codegen/tests/test_spec_sync.py: 45 passed.uv run pytest codegen/tests -k "vector or breaking": 94 passed, including the generator determinism test incodegen/tests/test_breaking_vectors.py.shasum -a 256 openapi/breaking-vectors.jsonmatches sdk-node, sdk-go and sdk-javamain.🤖 Generated with Claude Code