Repository navigation
didww-to-livekit: encrypt trunks by default and take the SIP URI from project settings - #1
Merged
Conversation
… project settings Verified end to end on LiveKit Cloud. connect.py defaults to TLS and required SRTP, takes --sip-uri instead of deriving the host from the Project URL, and gains --outbound-only. The skill and its doc page say the DIDWW outbound trunk is created in the panel, since the DIDWW MCP has no outbound trunk tools, and the failure map follows the responses seen in testing. didww-connect: LiveKit dashboard labels corrected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
didww-to-livekitskill after testing it end to end against LiveKit Cloud, inbound and outbound, with plain trunks and with TLS plus SRTP.didww-to-livekit1.1.0connect.pynow defaults to--transport tls --srtp require. The skill sets the DIDWW inbound trunk to port 5061, TLS and SRTP SDES, and asks for SRTP SDES on the DIDWW outbound trunk. Plain trunks are an opt-out:--transport tcp --srtp disable.connect.pytakes--sip-uriorLIVEKIT_SIP_URIand prints a placeholder without it.--outbound-only. Adds the outbound trunk to a project that already has the inbound trunk and dispatch rule. Re-running the full command created a second inbound trunk.media.encryption. The deprecated top-levelmedia_encryptionfield is no longer sent.400 Bad Requestinbound and500 No suitable mediaoutbound on an SRTP mismatch,484for an incomplete number, and404is not caused by a missing+.docs/didww-to-livekit.mdcarries the same changes.didww-connect1.0.1Wording only: LiveKit dashboard labels and the SIP URI description.
Not in this change
Six other outbound skills and their doc pages still say the DIDWW MCP creates the outbound trunk and sets spend limits. That is left for a separate change.
Test plan
bash scripts/test.sh: all Python tests pass, 30/30 fordidww-to-livekittest.shdid not run locally (nonodeon the machine); CI needs to cover themconnect.py, TLS and SRTP, on LiveKit Cloudconnect.py --outbound-only, TLS and SRTP, on LiveKit Cloud🤖 Generated with Claude Code