Repository navigation
Security and correctness review: installers, webhook server, Vapi flow, request shapes - #5
Merged
Merged
Conversation
…w, request shapes
- All nine installers refuse a --dest they do not own (home, skills root,
package, foreign folders), a bare --dest and unknown options; new
scripts/test_installers.py runs every installer against a temp HOME.
- OpenAI webhook server: requires the signing secret, exact To match,
body cap + timeout + threads, webhook-id dedup, working transfer
(transfer_call tool, call websocket, refer with target_uri).
- Vapi: rebuilt on the flow documented by Vapi and DIDWW (sip.vapi.ai,
inbound credential with DIDWW's signaling IPs, E.164 with +,
max_transfers + Authorization); --eu uses api.eu.vapi.ai; --rotate.
- Ultravox: allowedAgents as {agentId, toUserPattern}; --allow-didww;
0.0.0.0/0 refused; secrets redacted.
- ElevenLabs: provider (not provider_type) per the OpenAPI schema;
outbound optional.
- xAI: one-time secret saved to a 0600 file, masked on screen.
- Monitor: failed checks warn, pagination at 100 via links.next,
exact --number match, https only.
- Retell/Vogent: no null passwords; LiveKit: https/wss except localhost;
passwords from env vars; strict flag parsing everywhere.
- Version bumps, CHANGELOG, docs pages.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a security and enhancement review of all nine skills. Every finding was reproduced in code and checked against the vendor's own docs or OpenAPI schema before fixing; a few review claims were corrected on the way (see below), and the check turned up bugs the review missed.
Security
--dest ~would have moved the home directory into the backups. They now refuse home,~/.claude, the skills root, the backups folder, the package itself, folders holding another skill or other files, a bare--destand unknown options. Newscripts/test_installers.py(90 checks) runs every real installer against a temporary HOME.webhook-iddedup (recorded only after success so retries still work). Docs: the number match is routing, not authentication; keep the project ID private.0.0.0.0/0;--allow-didwwsets DIDWW's ranges; fallback secret redacted unless--show-secrets.http:///ws://refused except localhost. Monitor:DIDWW_API_BASEmust be https; pagination never follows another host.nullpassword; echoed responses mask passwords.Correctness
sip.vapi.ai/sip.eu.vapi.ai, inbound credential with DIDWW's seven signaling IPs, outbound credential, number in E.164 with+,max_transfers1 + Authorization for REFER.--eunow targetsapi.eu.vapi.ai(it only changed the printout).--rotatereplaces the documented-but-missing--update.allowedAgentsis an array of{agentId, toUserPattern}per the OpenAPI schema (strings were sent).provider: "sip_trunk"per the OpenAPI schema (provider_typedoes not exist); outbound optional so inbound can go live first.transfer_calltool, call websocket watcher andreferwithtarget_uri.--numberwas a substring match.Review claims corrected
0.0.0.0/0).Note for DIDWW docs
doc.didww.com's Vapi guide lists EU Vapi IPs
44.233.34.47/32,44.233.34.48/32; Vapi's networking page lists EU63.182.83.170/32. The skills follow Vapi's page.Versions: openai-realtime, vapi, ultravox, elevenlabs 1.1.0; livekit 1.1.1; connect, retell, vogent, xai 1.0.2.
bash scripts/test.shgreen locally (248 checks).