Repository navigation
build: install JDK 11 through SDKMAN on JitPack - #67
Merged
Merged
Conversation
The JitPack build image has no JDK 11 behind jdk: openjdk11 (JAVA_HOME points to a missing /usr/lib/jvm/jdk-11), so the build fails before Gradle starts. Install and select JDK 11 through SDKMAN instead.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install JDK 11 through SDKMAN on JitPack.
jdk: openjdk11(#65) does not work on the current JitPack build image: JitPack pointsJAVA_HOMEto/usr/lib/jvm/jdk-11, which the image does not have, and the build fails before Gradle starts. This installs and selects JDK 11 through SDKMAN inbefore_install, as the JitPack docs suggest for a specific Java version.The same
jitpack.ymlwas built on JitPack by commit on top ofrelease-4.1:BUILD SUCCESSFULon OpenJDK 11.0.32, with the jar, sources and javadoc artifacts. It is also used for the 4.1.4 release.