Fix TypeError on NetBox 4.6 list views (Django 6.0 format_html change)#17
Merged
Merged
Conversation
Django 6.0 (shipped with NetBox 4.6) raises TypeError when format_html()
is called without placeholders or args; previous versions only emitted a
DeprecationWarning. This broke the maintenance-plans and upcoming list
views with `TypeError: args or kwargs must be provided.`
Replaced 10 static `format_html('<span ...>literal</span>')` calls in
tables.py with `mark_safe(...)`. The one remaining `format_html('... {} ...',
abs(days))` call uses a placeholder and positional arg, so it stays valid
under Django 6.0. Bumped plugin to v1.3.1 and updated docs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
diegogodoy06
added
bug
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django 6.0 (shipped with NetBox 4.6) raises TypeError when format_html() is called without placeholders or args; previous versions only emitted a DeprecationWarning. This broke the maintenance-plans and upcoming list views with
TypeError: args or kwargs must be provided.Replaced 10 static
format_html('<span ...>literal</span>')calls in tables.py withmark_safe(...). The one remainingformat_html('... {} ...', abs(days))call uses a placeholder and positional arg, so it stays valid under Django 6.0. Bumped plugin to v1.3.1 and updated docs.