feat: add font feature settings support by stefanwittwer · Pull Request #2740 · diegomura/react-pdf

stefanwittwer · 2024-05-05T10:08:13Z

Implements #2155.

This PR adds the fontFeatureSettings style property (see MDN for the CSS equivalent). It takes a list of feature tags, which appends to the default set, or an object to turn on/off individual features, as supported by fontkit.

Why it matters

This allows users to apply any font features supported by a given font, such as tabular numbers, fractions, alternate glyphs, control over ligatures, etc.

Usage

const styles = StyleSheet.create({
  numeric: {
    fontFeatureSettings: ['tnum'],
  }
});

Example

A full example is provided in the examples package. Here's how it looks like:

changeset-bot · 2024-05-05T10:08:17Z

🦋 Changeset detected

Latest commit: 6430ed1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@react-pdf/textkit	Minor
@react-pdf/layout	Minor
@react-pdf/types	Minor
@react-pdf/render	Patch
@react-pdf/renderer	Patch
@react-pdf/font	Patch
@react-pdf/stylesheet	Patch
next-14	Patch
next-15	Patch
@react-pdf/vite-example	Patch
@react-pdf/e2e-node-cjs	Patch
@react-pdf/e2e-node-esm	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

stefanwittwer · 2024-05-05T10:10:24Z

I'm of course also happy to extend the documentation site accordingly if this will be merged, I'd just need a pointer as to where I could contribute that.

bdkopen · 2024-05-05T18:22:23Z

I'm of course also happy to extend the documentation site accordingly if this will be merged, I'd just need a pointer as to where I could contribute that.

The website documentation is kept in the react-pdf-site repository.

samueldrai · 2024-07-19T11:43:44Z

Hi!
Any news about this issue? Happy to help if needed :)

samueldrai · 2024-10-23T14:27:04Z

Up!
Any update on this? Happy to help :)

stefanwittwer · 2024-10-24T06:35:39Z

I'm also happy to change anything needed for this to be merged :) Is there a process for getting this PR reviewed?

samueldrai · 2024-10-31T16:36:11Z

If anything can be done to merge this PR, please reach out. :)

samueldrai · 2024-12-03T14:57:27Z

Up, is there anything I can do to help this PR being merged? :)

bnlb · 2024-12-05T22:36:00Z

This PR would help my team. Happy to help write documentation or assist where I can if it'd help get this approved.

samueldrai · 2024-12-11T13:16:47Z

Same as @bnlb. Happy to help for testing or writing docs :)

stefanwittwer · 2024-12-11T15:52:36Z

@diegomura Any pointers on how to get this PR reviewed? :)

samueldrai · 2024-12-19T13:05:14Z

Hi!
Any updates on this PR being merged? As usual, feel free to reach out if you need any help :)

samueldrai · 2025-01-07T14:11:24Z

Hi!

Happy new year :)

Any updates on this PR? As always, more than happy to help however I can!

samueldrai · 2025-02-07T12:41:38Z

Hi!
Any updates on this PR? Happy to contribute or help (docs, tests or anything else)>
@diegomura @stefanwittwer

samueldrai · 2025-02-20T13:54:08Z

Hi!
Any updates on this PR? Always happy to help if needed. :)

stefanwittwer · 2025-02-22T15:39:43Z

This PR was a bit out of date by now, so I integrated all latest changes into it and resolved the conflicts.
Everything works again, as can be seen in the associated example.

@diegomura Just let me know there's anything else I can do to help the maintainers out here, or if there are any other blockers before it can be reviewed :)

Support for tabular numbers with this would be extremely useful for use cases where react-pdf is used to generate reports, etc. Worth noting also that everything needed here was already supported out-of-the-box by Fontkit, so this addition should not stand in the way of the goal of merging the PDFKit fork with the original.

samueldrai · 2025-03-19T14:07:32Z

Hello there !
Any news regarding this PR? As always, happy to help. :)

samueldrai · 2025-04-22T12:05:28Z

Hi!
Any news? As always, please reach out if I can do anything to help :)
Sam

stefanwittwer · 2025-04-22T12:31:40Z

@samueldrai It seems the layout package has been converted to TypeScript now on the main branch in #3092 and subsequent PRs. Would you be willing to help me bring my PR back to speed with all newer changes? I'm currently missing the time to do it unfortunately, but I'll accept your contribution on my fork for this PR. Hopefully that makes a path for this to get merged at some point

samueldrai · 2025-04-22T12:49:15Z

Of course, I'll get this done this done whenever I can @stefanwittwer :)

Implements diegomura#2155. Adds the fontFeatureSettings style property for CSS equivalent support. Takes a list of feature tags which appends to the default set, or an object to turn on/off individual features, as supported by fontkit. Allows users to apply font features like tabular numbers, fractions, alternate glyphs, control over ligatures, etc.

MendyLanda · 2025-06-15T14:06:32Z

@samueldrai @stefanwittwer, i needed this and a few other fixes and features. idk why all these PRs are not being merged and I'm tired of waiting, so (for now at least) I forked react-pdf and republished under @rpdf/*
see here https://github.com/MendyLanda/react-pdf

I don't have time for actively improving it, but reviewing and merging PRs is definitely doable.

MendyLanda · 2025-06-15T14:06:47Z

thank you for this PR!

Added font feature settings to TextStyle Adapted example to new structure

stefanwittwer · 2025-10-20T14:48:49Z

I've now brought this older PR up-to-date again by rebasing it onto the current master, to make sure it can be cleanly merged again. I also integrated the nice type-safety improvements that @MendyLanda added in his fork, thanks a lot!

Example is again up and running flawlessly:

@wojtekmaj @diegomura - Any pointers on how to get this PR reviewed by maintainers? It's been open for quite a while without any feedback. It certainly seems highly requested by the community judging by the previous comments in this thread :) Happy to help out where I can!

wojtekmaj

I am NOT a maintainer 😂 but LGTM!

stefanwittwer · 2025-10-22T08:18:28Z

@wojtekmaj Ah sorry😂 I assumed because your GitHub bio says so haha. Thanks for reviewing!

wojtekmaj · 2025-10-22T11:18:16Z

@stefanwittwer It IS true! But please do mind: https://github.com/diegomura/react-pdf#lost

manuelmeister · 2026-06-11T10:05:07Z

With this PR, the issue #1664 would also be resolved

manuelmeister · 2026-06-11T10:07:52Z

  characterSpacing?: number;
  color?: string;
-  direction?: 'rtl' | 'ltr';
+  direction?: FontFeatureSettings;


@stefanwittwer I think this change is incorrect.

Created a PR stefanwittwer#1

diegomura force-pushed the master branch from 15f2ccd to 9075655 Compare November 17, 2024 09:35

stefanwittwer force-pushed the master branch from f33ad19 to 3bd1a79 Compare February 22, 2025 15:12

MendyLanda mentioned this pull request Jun 15, 2025

feat: add font feature settings support MendyLanda/react-pdf#2

Merged

feat: add font feature settings support

878a36d

Added font feature settings to TextStyle Adapted example to new structure

stefanwittwer force-pushed the master branch from 3bd1a79 to 878a36d Compare October 20, 2025 14:30

Strongly typed font feature settings

6430ed1

wojtekmaj approved these changes Oct 21, 2025

View reviewed changes

diegomura force-pushed the master branch from c7413a7 to 464b3f1 Compare April 5, 2026 00:54

manuelmeister reviewed Jun 11, 2026

View reviewed changes

manuelmeister mentioned this pull request Jun 11, 2026

feat(layout): support fontFeatureSettings in text rendering #3440

Open

Uh oh!

Conversation

stefanwittwer commented May 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why it matters

Usage

Example

Uh oh!

changeset-bot Bot commented May 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

stefanwittwer commented May 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bdkopen commented May 5, 2024

Uh oh!

samueldrai commented Jul 19, 2024

Uh oh!

samueldrai commented Oct 23, 2024

Uh oh!

stefanwittwer commented Oct 24, 2024

Uh oh!

samueldrai commented Oct 31, 2024

Uh oh!

samueldrai commented Dec 3, 2024

Uh oh!

bnlb commented Dec 5, 2024

Uh oh!

samueldrai commented Dec 11, 2024

Uh oh!

stefanwittwer commented Dec 11, 2024

Uh oh!

samueldrai commented Dec 19, 2024

Uh oh!

samueldrai commented Jan 7, 2025

Uh oh!

samueldrai commented Feb 7, 2025

Uh oh!

samueldrai commented Feb 20, 2025

Uh oh!

stefanwittwer commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samueldrai commented Mar 19, 2025

Uh oh!

samueldrai commented Apr 22, 2025

Uh oh!

stefanwittwer commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samueldrai commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MendyLanda commented Jun 15, 2025

Uh oh!

MendyLanda commented Jun 15, 2025

Uh oh!

stefanwittwer commented Oct 20, 2025

Uh oh!

wojtekmaj left a comment

Choose a reason for hiding this comment

Uh oh!

stefanwittwer commented Oct 22, 2025

Uh oh!

wojtekmaj commented Oct 22, 2025

Uh oh!

manuelmeister commented Jun 11, 2026

Uh oh!

manuelmeister Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

manuelmeister Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

stefanwittwer commented May 5, 2024 •

edited

Loading

changeset-bot Bot commented May 5, 2024 •

edited

Loading

stefanwittwer commented May 5, 2024 •

edited

Loading

stefanwittwer commented Feb 22, 2025 •

edited

Loading

stefanwittwer commented Apr 22, 2025 •

edited

Loading

samueldrai commented Apr 22, 2025 •

edited

Loading