fix(templates:common): Lint bower.json before executing wiredep.#200
Open
Yatoom wants to merge 1 commit intodiegonetto:masterfrom
Open
fix(templates:common): Lint bower.json before executing wiredep.#200Yatoom wants to merge 1 commit intodiegonetto:masterfrom
Yatoom wants to merge 1 commit intodiegonetto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend linting bower.json before running wiredep. When there is, say, a trailling comma in bower.json and the wiredep task (
grunt wiredep) is executed, the user will not get a very helpful message:You see, the error could be in any file. By running
jsonlintfirst, we get a much more helpful error message.If everything is fine, the user will see the following messages: