Skip to content

fix(app): resolve sidebar status indicator issues #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeanMeijer wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −4
Open

fix(app): resolve sidebar status indicator issues #2074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/app/src/react-app/domains/session/sidebar/app-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function SessionStatusIndicator({ className, status, isStreaming, isActive }: Se
return (
<span
className={cn(
"size-1.5 shrink-0 rounded-full",
"size-1.5 shrink-0 rounded-full bg-muted-foreground",
status === "waiting" && "bg-sky-9",
status === "error" && "bg-red-9",
className,
Expand Down Expand Up @@ -1393,7 +1393,7 @@ function SessionMenuItem({
>
<PinnedIndicator isPinned={isPinned} />
<span
className={cn("min-w-0 flex-1 truncate transition-[padding] duration-75 group-hover/menu-sub-item:pe-12 group-has-data-popup-open/menu-sub-item:pe-12 pe-4", isSessionStreaming || isSessionActive && "pe-12")}
className={cn("min-w-0 flex-1 truncate transition-[padding] duration-75 group-hover/menu-sub-item:pe-12 group-has-data-popup-open/menu-sub-item:pe-12 pe-4", (isSessionStreaming || isSessionActive) && "pe-12")}
title={displayTitle}
>
{displayTitle}
Expand All @@ -1412,7 +1412,7 @@ function SessionMenuItem({
isArchived={isArchived}
className="absolute right-9 top-1/2 -translate-y-1/2 opacity-0 group-hover/menu-sub-item:opacity-100 data-popup-open:opacity-100"
/>
<SessionStatusIndicator className="absolute right-9 top-1/2 -translate-y-1/2 opacity-0 group-hover/menu-sub-item:opacity-0 group-has-data-popup-open/menu-sub-item:opacity-0 pointer-events-none select-none" status={sessionActivityStatus} isStreaming={isSessionStreaming} isActive={isSessionActive} />
<SessionStatusIndicator className="absolute right-9 top-1/2 -translate-y-1/2 opacity-100 group-hover/menu-sub-item:opacity-0 group-has-data-popup-open/menu-sub-item:opacity-0 pointer-events-none select-none" status={sessionActivityStatus} isStreaming={isSessionStreaming} isActive={isSessionActive} />
</SidebarMenuSubItem>
</Collapsible>
) : (
Expand All @@ -1423,7 +1423,7 @@ function SessionMenuItem({
onClick={openSession}
onPointerEnter={prefetchSession}
onFocus={prefetchSession}
className={cn("transition-[padding] duration-75 group-hover/menu-sub-item:pe-8 group-has-data-popup-open/menu-sub-item:pe-8", depth > 0 && "ps-13", isSessionStreaming || isSessionActive && "pe-8")}
className={cn("transition-[padding] duration-75 group-hover/menu-sub-item:pe-8 group-has-data-popup-open/menu-sub-item:pe-8", depth > 0 && "ps-13", (isSessionStreaming || isSessionActive) && "pe-8")}
>
<PinnedIndicator isPinned={isPinned} />
<span className="truncate" title={displayTitle}>{displayTitle}</span>
Expand Down
Loading