Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions apps/app/scripts/artifacts.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,24 @@ describe("getArtifactsFromMessages", () => {
exists: true,
});
});

it("does not include verified targets unrelated to the local message group", () => {
const messages: UIMessage[] = [{
id: "msg_later",
role: "assistant",
parts: [{ type: "text", text: "Done.", state: "done" }],
}];
const targets: OpenTarget[] = [{
id: "file:reports/earlier.csv",
kind: "file",
value: "reports/earlier.csv",
name: "earlier.csv",
preview: "sheet",
confidence: 95,
reason: "write tool metadata",
exists: true,
}];

expect(getArtifactsFromMessages(messages, targets)).toEqual([]);
});
});
16 changes: 13 additions & 3 deletions apps/app/src/lib/artifacts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,15 @@ function getArtifactPathsFromMessage(message: UIMessage) {
return paths.map((path) => path?.trim().toLowerCase()).filter((path) => path) as string[];
}

function getArtifactTextFromMessages(messages: UIMessage[]) {
return messages
.flatMap((message) => message.parts.flatMap((part) => {
if (part.type === "text") return [part.text.toLowerCase()];
return [];
}))
.join("\n");
}

function addArtifact(
artifacts: Map<string, ArtifactItem>,
path: string,
Expand All @@ -260,6 +269,7 @@ function addArtifact(

export function getArtifactsFromMessages(messages: UIMessage[], openTargets: OpenTarget[] = []) {
const artifacts = new Map<string, ArtifactItem>();
const artifactText = getArtifactTextFromMessages(messages);

for (const message of messages) {
for (const path of getArtifactPathsFromMessage(message)) {
Expand All @@ -269,9 +279,9 @@ export function getArtifactsFromMessages(messages: UIMessage[], openTargets: Ope

const fallbackMessageId = messages[messages.length - 1]?.id ?? "open-target";
for (const target of openTargets) {
if (isCollectibleArtifactTarget(target)) {
addArtifact(artifacts, target.value, fallbackMessageId, openTargets, target);
}
if (!isCollectibleArtifactTarget(target)) continue;
if (!artifactText.includes(normalizeArtifactPath(target.value).toLowerCase())) continue;
addArtifact(artifacts, target.value, fallbackMessageId, openTargets, target);
}

return [...artifacts.values()];
Expand Down
Loading