[codex] Add quickstart verify local proofs#122
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the quickstart-verify entry point so it can execute a small set of safe local proofs (non-device-touching), persist the quickstart plan / evaluation proof pack handoff artifacts into the command artifact root, and surface the new proof results in both JSON envelopes and human output. This aligns with Luotsi’s “first-five-minute” workflow by making the initial proof/evidence handoff more explicit and durable without implicitly running device-affecting checks.
Changes:
- Make
quickstart-verifyasynchronous and writequickstart-plan.*,evaluation-proof-pack.*, plus refreshed artifact indexes into the command artifact root. - Add new envelope fields for local proof reporting:
local_proof_count,passed_local_proof_count, andlocal_proofs[]; update human formatter accordingly. - Update docs (README, command docs, website docs, help text) and extend tests to validate the new outputs and artifact writes.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
website/src/content/docs/docs/reference/output-envelopes.mdx |
Documents local_proofs[] in quickstart envelopes/verify behavior. |
website/src/content/docs/docs/getting-started/quickstart.mdx |
Updates quickstart guidance to reflect quickstart-verify writing local handoff artifacts + reporting local proofs. |
website/src/content/docs/docs/getting-started/first-five-minutes.mdx |
Updates first-five-minutes workflow text to include the new verify behavior. |
README.md |
Updates workflow quickstart section to describe local proof execution + artifact handoff from quickstart-verify. |
Luotsi.Cli/Cli/Routing/QuickstartCommand.cs |
Implements VerifyAsync(...), runs local proofs, writes handoff artifacts into the command artifact root, and extends verify result schema. |
Luotsi.Cli/Cli/Routing/AppCommandDispatcher.cs |
Switches dispatch to await QuickstartCommand.VerifyAsync(...). |
Luotsi.Cli/Cli/Help.cs |
Updates help text describing quickstart-verify producing handoff artifacts + local proof reporting. |
Luotsi.Cli/Cli/Envelope/AppCommandHumanFormatter.cs |
Adds local proof counts and summaries to human output for quickstart-verify. |
Luotsi.Cli.Tests/CommandEnvelopeTests.cs |
Adds/updates tests validating new verify envelope fields and that expected handoff files + index are written. |
docs/commands.md |
Updates command documentation to reflect the new quickstart-verify behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quickstart-verifyexecute safe local proofs while keeping device-touching checks explicit.quickstart-plan.*,evaluation-proof-pack.*, and refreshed artifact indexes into the command artifact root.local_proof_count,passed_local_proof_count, andlocal_proofsin JSON/human output.Validation
dotnet test Luotsi.Cli.Tests/Luotsi.Cli.Tests.csproj --configuration Release --no-builddotnet build Luotsi.sln --configuration Release --no-restore --warnaserrorgit diff --checkquickstart-verifysamples confirmed the handoff artifacts are written.npm ciandnpm run buildinwebsite.