[codex] Use generic selector examples#128
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR generalizes previously kiosk-specific examples and wording to be device/generic across docs and tests, reducing accidental coupling to a specific third-party app/package while keeping examples representative.
Changes:
- Replaced
com.elotouch.home:id/tvAppNameselector examples with a genericcom.example.app:id/itemTitleacross docs, examples, and tests. - Updated live-view workflow docs to use a more generic saved profile name (
lab-device). - Generalized telemetry parser XML-doc wording from “kiosk telemetry” to “device telemetry”.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/content/docs/docs/reference/scenario-playbooks.mdx | Updates selector example to use a generic resource ID. |
| website/src/content/docs/docs/core-workflows/live-view.mdx | Uses a generic saved profile name in live-view command examples. |
| website/src/content/docs/docs/core-workflows/ai-agent-workflows.mdx | Updates JSONL agent command example to use a generic resource ID. |
| website/src/content/docs/docs/core-workflows/agent-loop-example.mdx | Updates agent-loop CLI + JSONL examples to use a generic resource ID. |
| Luotsi.Cli/Telemetry/LuotsiDeviceTelemetryParser.cs | Generalizes XML-doc summary wording for the telemetry parser. |
| Luotsi.Cli.Tests/ScenarioExecutorTests.cs | Updates selector test data to match the new generic resource ID. |
| Luotsi.Cli.Tests/DeviceRunnerTests.cs | Updates UI dump test data / selector to the new generic resource ID. |
| Luotsi.Cli.Tests/CommandEnvelopeTests.cs | Updates inspect/replay selector metadata fixtures and assertions to the new generic resource ID. |
| examples/agents/README.md | Updates documented agent-loop invocation example to the generic resource ID. |
| docs/scenarios.md | Updates selector example to use a generic resource ID. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary