Skip to content

[codex] Use generic selector examples#128

Merged
slideep merged 1 commit into
mainfrom
codex/generic-selector-examples
Jun 12, 2026
Merged

[codex] Use generic selector examples#128
slideep merged 1 commit into
mainfrom
codex/generic-selector-examples

Conversation

@slideep

@slideep slideep commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Generalize the telemetry parser summary from kiosk-specific wording to device telemetry wording.

@slideep
slideep marked this pull request as ready for review June 12, 2026 18:06
Copilot AI review requested due to automatic review settings June 12, 2026 18:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR generalizes previously kiosk-specific examples and wording to be device/generic across docs and tests, reducing accidental coupling to a specific third-party app/package while keeping examples representative.

Changes:

  • Replaced com.elotouch.home:id/tvAppName selector examples with a generic com.example.app:id/itemTitle across docs, examples, and tests.
  • Updated live-view workflow docs to use a more generic saved profile name (lab-device).
  • Generalized telemetry parser XML-doc wording from “kiosk telemetry” to “device telemetry”.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/src/content/docs/docs/reference/scenario-playbooks.mdx Updates selector example to use a generic resource ID.
website/src/content/docs/docs/core-workflows/live-view.mdx Uses a generic saved profile name in live-view command examples.
website/src/content/docs/docs/core-workflows/ai-agent-workflows.mdx Updates JSONL agent command example to use a generic resource ID.
website/src/content/docs/docs/core-workflows/agent-loop-example.mdx Updates agent-loop CLI + JSONL examples to use a generic resource ID.
Luotsi.Cli/Telemetry/LuotsiDeviceTelemetryParser.cs Generalizes XML-doc summary wording for the telemetry parser.
Luotsi.Cli.Tests/ScenarioExecutorTests.cs Updates selector test data to match the new generic resource ID.
Luotsi.Cli.Tests/DeviceRunnerTests.cs Updates UI dump test data / selector to the new generic resource ID.
Luotsi.Cli.Tests/CommandEnvelopeTests.cs Updates inspect/replay selector metadata fixtures and assertions to the new generic resource ID.
examples/agents/README.md Updates documented agent-loop invocation example to the generic resource ID.
docs/scenarios.md Updates selector example to use a generic resource ID.

@slideep
slideep merged commit 6b90026 into main Jun 12, 2026
13 checks passed
@slideep
slideep deleted the codex/generic-selector-examples branch June 12, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants