Repository navigation
Ad landing page: two long buttons with an "or" line - #49
Merged
Merged
Conversation
Both form buttons are full width and the same size (56px tall, round icon chip at the right edge, label centred beside it). Colour tells them apart: dark for Pay now, light copper for Talk to us. "Cancel anytime." sits between them and the "or" divider is gone.
Pay now, "Cancel anytime.", a full-width "or" line, then Talk to us. Both buttons keep the same long size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this releases
The ad landing page's form buttons, in their final layout (two commits). Nothing else changes.
This replaces the side-by-side buttons that went out in #48. No copy, price or address changes, and the form, country dropdown and the sealed sign-up link are untouched.
Checked
npm run lint,npm run typecheck,npm test(501),npm run buildandnpm run verify:htmlall pass. Checked on a local server at 375px and on desktop: both buttons measure the same, the chips sit at the right edge, and the order is as above. Playwright e2e was not run locally; CI should cover it.Note
The
checkjob on GitHub fails before it starts because of the account's billing problem ("recent account payments have failed or your spending limit needs to be increased"), as on the previous release PRs. That is not a result of this change.