Repository navigation
Fix infra lint notes and show search volume in the Trend column - #24
Merged
Merged
Conversation
Tracked keyword metrics now carry monthly_searches (the provider's months behind the trend, oldest first). The Trend column draws the last 12 months as a sparkline, higher volume higher up, on each row's own scale, with a month without a volume breaking the line. The rows no longer ask for include=sparkline. The design preview, the API contract and the docs follow.
Rewrite the A && B || die checks as explicit if statements with the same behaviour. The infra lint job fails on these info notes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this holds
A && B || diechecks ininfra/deploy.sh,infra/ci/resolve-release.shandinfra/test/parallel-stack.shbecome explicitifstatements with the same behaviour. This clears the shellcheck SC2015 notes that fail the infra lint job. Shellcheck exits 0 with the command CI runs, and the offline release-resolver test passes.Notes
infra/test/deploy-dryrun.sh) was not run locally because it needs local images; CI covers it.