Repository navigation
Fix the five failing web unit tests and the ranking pages card overflow - #27
Merged
Merged
Conversation
… card The page column truncates with the full path in its title, and the rank column has a fixed width. Also correct the strip's comments: its count is of the device shown.
The strip test follows the mock's current counts, the bucket test counts the desktop rows the table shows, the invite test uses a refusal the mock still gives (a password may contain the email name now), and the mock's budget month follows Date.now so a month change does not move it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
… timeout The backend job ran 4,120 tests one at a time and needed about 45 minutes, so it hit its 15 minute limit on every run and no image was ever pushed. With pytest-xdist on 4 workers (each with its own PostgreSQL, Redis and object store containers) the full suite with coverage takes 7.5 minutes on a 4-CPU machine. The job limit goes to 30 minutes for a slower runner. The workflow also runs when infra/compose/postgres/initdb changes, because the tests build their database from those role scripts.
CI: backend tests on 4 workers, so the job finishes inside its timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR 26 merged but nothing deployed: the web checks on
mainfail on five old unit tests, and the deploy workflow skips a release whose checks fail. This PR fixes them, plus one popup bug.Changes
main:Date.now, so a month change does not move itChecks
Lint, typecheck, format check and the full unit suite pass locally. The one local failure is the dash check on an untracked, generated
apps/web/AGENTS.mdthat CI does not have.Deploy
Unchanged: backend first, then web. The backend run on
mainwas cancelled during its tests last time, so watch that one.