Add input references to runtime and run_prcess_as_root#279
Merged
Conversation
|
This PR updates the following pallets - they may also require updates to their extrinsic weights: For the author and any reviewers:
For a guide on running benchmarks to update weights see calculating weights |
cbc5c45 to
1f639c2
Compare
Ellenn-A
reviewed
May 7, 2025
… input to an input
Ellenn-A
reviewed
May 19, 2025
Ellenn-A
reviewed
May 19, 2025
Ellenn-A
reviewed
May 20, 2025
Contributor
Ellenn-A
left a comment
There was a problem hiding this comment.
read through, didn't notice anything obvious
jonmattgray
approved these changes
May 20, 2025
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
PR Type
Please delete options that are irrelevant.
Linked tickets
https://digicatapult.atlassian.net/browse/SQNC-166
High level description
Adds the ability to pass referenced tokens that won't be burnt to
run_processand the ability to run processes asrootthrough a newrun_process_as_rootextrinsic. In addition restriction types have been modified to allow us to restrict references and also to limit the sender to beingroot.Detailed description
The change here contans several opinionated decisions that need to be considered:
input/outputrestrictions. This was to avoid adding a whole copy of the set of restrictions forreferencespallet-process-validationFinally this PR will be followed up with:
Describe alternatives you've considered
The initial plan assumed some sort of permissions system built into the restrictions that could be role based. After discussons with @rmlearney-digicatapult and @Ellenn-A this felt too restrictive and the decisaion was made to encode these privileges into issuable tokens instead.
We should consider the security implications of this design change as anyone who can now create one of these tokens can change privileges in the system. That said if you can manipulate the process flows you could change anything anyway so this is probably fine.
Operational impact
This change implements two migrations in the runtime that affect the storage of
pallet-utxo-nftandpallet-process-validation. These should be removed once this is released.This change will break matchmaker and will require downtime. This change should not be merged until that change is ready.
Additional context
None