Improve S3 URL Expiration Detection and Retry Logic #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115
Fix to detect and handle expiring S3 URLs in fresh content fetched from Notion.
Changes
URL Expiration Check (imageReplacer.ts)
isUrlExpiringSoon(url, thresholdSeconds)utilityValidation & Retry in Cache Loaders (cacheLoaders.ts)
loadWithCacheto accept avalidateResultfunctionloadBlocksForPage: checking blocks JSON for expiring URLsloadMarkdownForPage: checking markdown string for expiring URLsUnit Tests
scripts/notion-fetch/__tests__/urlExpiration.test.tsto verify expiration logicVerification Results