feat: apply node/chain deep-link params with user confirmation - #19
Open
digitalSloth wants to merge 1 commit into
Open
digitalSloth wants to merge 1 commit into
digitalSloth wants to merge 1 commit into
Conversation
A URL can carry node/chainId/networkId query params so a link can point the wallet at a specific network (e.g. a testnet). The wallet boots normally on its current network, then shows a confirmation dialog naming the exact node and chain/network IDs a link is requesting nothing is applied until the user explicitly approves. On confirm, the dialog stays open with a disabled "Connecting..." state while the change is verified via the existing changeNode/ updateNetworkConfig path (the same one the network settings UI uses), which checks reachability before persisting. On failure the dialog shows the error inline with a retry option, and the chain/network id is rolled back to its previous value so a failed switch never leaves the wallet on its old node paired with a mismatched chain id. Declining or cancelling leaves the current network untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A URL can carry node/chainId/networkId query params so a link can point the wallet at a specific network (e.g. a testnet). The wallet boots normally on its current network, then shows a confirmation dialog naming the exact node and chain/network IDs a link is requesting nothing is applied until the user explicitly approves.
On confirm, the dialog stays open with a disabled "Connecting..." state while the change is verified via the existing changeNode/ updateNetworkConfig path (the same one the network settings UI uses), which checks reachability before persisting. On failure the dialog shows the error inline with a retry option, and the chain/network id is rolled back to its previous value so a failed switch never leaves the wallet on its old node paired with a mismatched chain id. Declining or cancelling leaves the current network untouched.