fix: remove click-to-select substitution rules#39
Merged
Conversation
The ActionVerbs rule was flagging all instances of "click" for buttons, links, and checkboxes and suggesting "select" instead. This produced excessive false positives in PRs since "click" is standard and widely understood. The "type" to "enter" substitutions are retained. Also updates InputVerbs.yml to suggest "click" instead of "select" for button interactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionVerbs.ymlthat were flagging all uses of "click" for buttons, links, and checkboxes and suggesting writers use "select" instead. This was producing excessive noise in PRs since "click" is standard, widely understood, and acceptable in our docs.InputVerbs.ymlerror message to suggest "click" instead of "select" for button interactions (the rule still correctly flags "press the button" since "press" should be reserved for keyboard keys).Test plan