Skip to content

fix: remove click-to-select substitution rules#39

Merged
dfinn5-do merged 1 commit into
mainfrom
fix/remove-click-select-rule
Feb 11, 2026
Merged

fix: remove click-to-select substitution rules#39
dfinn5-do merged 1 commit into
mainfrom
fix/remove-click-select-rule

Conversation

@dfinn5-do
Copy link
Copy Markdown
Collaborator

Summary

  • Removes the click-to-select substitution rules from ActionVerbs.yml that were flagging all uses of "click" for buttons, links, and checkboxes and suggesting writers use "select" instead. This was producing excessive noise in PRs since "click" is standard, widely understood, and acceptable in our docs.
  • Retains the existing "type" to "enter" substitutions for text input fields, which remain valid guidance.
  • Updates the InputVerbs.yml error message to suggest "click" instead of "select" for button interactions (the rule still correctly flags "press the button" since "press" should be reserved for keyboard keys).

Test plan

  • Verify Vale no longer flags "click the Create button" or similar phrases
  • Verify "type in the name field" is still flagged with a suggestion to use "enter"
  • Verify "press the Submit button" is still flagged with updated message suggesting "click"

The ActionVerbs rule was flagging all instances of "click"
for buttons, links, and checkboxes and suggesting "select"
instead. This produced excessive false positives in PRs
since "click" is standard and widely understood. The
"type" to "enter" substitutions are retained. Also updates
InputVerbs.yml to suggest "click" instead of "select" for
button interactions.
@dfinn5-do dfinn5-do requested a review from a team as a code owner February 11, 2026 18:14
@dfinn5-do dfinn5-do merged commit 176e971 into main Feb 11, 2026
2 checks passed
@dfinn5-do dfinn5-do deleted the fix/remove-click-select-rule branch February 11, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant