Verify and confirm Git setup for main branch#33
Merged
digitalstore2025 merged 4 commits intomainfrom Apr 20, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Set up Git and push main branch
Verify and confirm Git setup for main branch
Apr 15, 2026
digitalstore2025
changed the base branch from
main
to
claude/ai-palestinian-broadcast-56tZN
digitalstore2025
changed the base branch from
claude/ai-palestinian-broadcast-56tZN
to
chore/deploy-ready-vite
digitalstore2025
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR substantially expands the repository by adding a new broadcast-ai/ Python subsystem for generating and serving broadcast-style Arabic audio/video (TV loop, radio, podcasts, scheduling, RSS integration), plus setup/bootstrap scripts and a new GitHub Actions workflow. This scope does not match the PR title/description, which describe only verifying Git setup for main.
Changes:
- Add a full Flask-based web UI + REST API for streaming, schedules, history, episodes, and on-demand TTS generation.
- Add broadcast generation pipelines (TV loop w/ optional Wav2Lip, radio mode, podcast generation, voiceover batch generation) with shared config/logging/RSS/scheduler utilities.
- Add setup/bootstrap scripts, dependency updates, repo ignore changes, and replace the GitHub workflow.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| broadcast-ai/voiceover.py | Adds voiceover generation utilities (single + batch) with optional ffmpeg padding. |
| broadcast-ai/tv_server.py | Replaces minimal streaming server with a full web UI + REST API endpoints. |
| broadcast-ai/train.py | Enhances training pipeline with dataset validation, CLI flags, and logging. |
| broadcast-ai/setup_wav2lip.sh | Adds automated Wav2Lip installation + model download verification. |
| broadcast-ai/setup.sh | Expands setup steps, verifies imports, creates directories, and documents quick start. |
| broadcast-ai/scheduler.py | Introduces time-based scheduling for broadcast content blocks. |
| broadcast-ai/run_tv_channel.py | Upgrades TV loop to schedule-aware generation with RSS and segment history. |
| broadcast-ai/rss_feed.py | Adds RSS fetching + caching + “unseen headlines” logic (atoma/stdlib fallback). |
| broadcast-ai/requirements.txt | Updates Python dependencies (adds atoma, imageio-ffmpeg; removes feedparser). |
| broadcast-ai/radio_station.py | Adds audio-only radio broadcast loop with optional bumper generation. |
| broadcast-ai/podcast_generator.py | Adds podcast episode generation and WAV concatenation via ffmpeg. |
| broadcast-ai/main.py | Adds unified launcher to run TV/radio/server/podcast/voiceover modes. |
| broadcast-ai/logger.py | Adds shared console+file logging helper. |
| broadcast-ai/generate.py | Adds style-based generation, caching, validation, retry logic, lazy TTS import. |
| broadcast-ai/download_quran_dataset.py | Adds Quran dataset downloader + metadata builder. |
| broadcast-ai/demo.py | Adds demo mode that runs without fine-tuning by using pre-trained XTTS v2. |
| broadcast-ai/config.py | Centralizes paths, audio params, schedules, RSS feeds, and content pools. |
| broadcast-ai/bootstrap.sh | Adds “one-command” bootstrap flow to install deps and launch demo. |
| broadcast-ai/README.md | Removes the previous broadcast-ai README (documentation removed). |
| broadcast-ai/.gitignore | Extends ignores for generated output, logs, and cache under broadcast-ai/. |
| .gitignore | Simplifies root ignore list and adds env/coverage/log ignores. |
| .github/workflows/jekyll-docker.yml | Removes the Jekyll CI workflow. |
| .github/workflows/build.yml | Adds a Node “Build and Test” workflow (currently build-only). |
| .env.example | Adds an example env file with placeholder secret keys/URLs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Reviewer's GuideRefines the broadcast AI dashboard’s podcast rendering to be DOM-based and URL-safe, hardens the TTS generation API error handling with logging, and updates the setup script to validate the new RSS dependency (atoma instead of feedparser). Sequence diagram for hardened TTS generation API error handlingsequenceDiagram
participant Client
participant FlaskApp
participant tv_server_api_generate
participant TTSGenerator as generate_voice
participant Logger as log
Client->>FlaskApp: POST /api/generate (text, style, output_name)
FlaskApp->>tv_server_api_generate: Call api_generate
tv_server_api_generate->>tv_server_api_generate: t0 = time.time()
tv_server_api_generate->>TTSGenerator: generate_voice(text, style, output_name)
alt Generation succeeds
TTSGenerator-->>tv_server_api_generate: path
tv_server_api_generate->>tv_server_api_generate: duration = round(time.time() - t0, 1)
tv_server_api_generate-->>FlaskApp: jsonify({path, duration, style})
FlaskApp-->>Client: 200 OK JSON
else Unhandled exception
TTSGenerator-->>tv_server_api_generate: Exception
tv_server_api_generate->>Logger: log.exception("Unhandled error during /api/generate request")
tv_server_api_generate-->>FlaskApp: jsonify({error: "Internal server error"}), 500
FlaskApp-->>Client: 500 JSON {error: Internal server error}
end
Flow diagram for DOM-based podcast episodes renderingflowchart TD
A["Fetch /api/episodes"] --> B{Response OK?}
B -- No --> C["Set episodes.innerHTML to خطأ في التحميل"]
B -- Yes --> D{episodes list empty?}
D -- Yes --> E["Set episodes.innerHTML to لا توجد حلقات بعد. شغّل podcast_generator.py لإنشاء حلقات."]
D -- No --> F["Clear container with episodes.replaceChildren()"]
F --> G["For each episode ep with index i"]
G --> H["Create item div and style margins, padding, border"]
H --> I["Create strong title with text حلقـة (i+1)"]
I --> J["Append separator text node —"]
J --> K["Create span name with class status and text ep.name"]
K --> L["Create audio element with controls, width 100%, marginTop 0.5rem"]
L --> M["Create source element"]
M --> N["Set source.src to /api/episode/ + encodeURIComponent(ep.name)"]
N --> O["Set source.type to audio/wav"]
O --> P["Append source to audio"]
P --> Q["Append audio to item"]
Q --> R["Append item to episodes container"]
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
/api/generateerror response has changed from returning the actual exception message to a generic "Internal server error" string; if any existing client logic relies on the previous error text, consider preserving it in a separate field (e.g.detail) or gating the new behavior behind a flag. - In the
podcasts_pagescript, you now usereplaceChildren()and explicit DOM creation for the success path but still setinnerHTMLdirectly in the.catchhandler; for consistency and to avoid potential HTML injection, consider updating the error path to also construct DOM nodes programmatically.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `/api/generate` error response has changed from returning the actual exception message to a generic "Internal server error" string; if any existing client logic relies on the previous error text, consider preserving it in a separate field (e.g. `detail`) or gating the new behavior behind a flag.
- In the `podcasts_page` script, you now use `replaceChildren()` and explicit DOM creation for the success path but still set `innerHTML` directly in the `.catch` handler; for consistency and to avoid potential HTML injection, consider updating the error path to also construct DOM nodes programmatically.
## Individual Comments
### Comment 1
<location path="broadcast-ai/tv_server.py" line_range="435-437" />
<code_context>
return jsonify({"path": path, "duration": duration, "style": style})
- except Exception as exc:
- return jsonify({"error": str(exc)}), 500
+ except Exception:
+ log.exception("Unhandled error during /api/generate request")
+ return jsonify({"error": "Internal server error"}), 500
</code_context>
<issue_to_address>
**suggestion:** The generic error response might make client-side debugging harder without an error identifier.
While the generic message improves security, it makes it harder for clients to correlate failures with server logs. Consider including an opaque error ID in the JSON response (e.g. `{"error": "Internal server error", "id": trace_id}`) and logging the same ID with the exception to preserve debuggability without exposing implementation details.
Suggested implementation:
```python
except Exception:
error_id = str(uuid.uuid4())
log.exception("Unhandled error during /api/generate request (error_id=%s)", error_id)
return jsonify({"error": "Internal server error", "id": error_id}), 500
```
Add `import uuid` alongside the other imports at the top of `broadcast-ai/tv_server.py`, for example:
<<<<<<< SEARCH
import time
=======
import time
import uuid
>>>>>>> REPLACE
If the import section differs, adjust the SEARCH block to match an existing nearby import line and insert `import uuid` appropriately.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
💡 Codex ReviewLine 196 in 45df5c5  Use unique temp WAV path per synthesis call
Lines 36 to 37 in 45df5c5  Verify ffmpeg availability after fallback install
In quick bootstrap mode without system ffmpeg, the script installs ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
|
@copilot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue requested initializing Git, committing all files, and pushing the main branch to the remote origin.
Findings
The repository was already fully configured — no changes were required:
.gitignorecorrectly excludesnode_modules,dist,.env*, and build artifacts.env.examplepresent with placeholders forGEMINI_API_KEYand other secretspackage.jsondefines all dependencies (react,react-dom,@google/genai) and dev tooling (vite,typescript,@vitejs/plugin-react)github.com/digitalstore2025/-All steps from the issue were satisfied by the existing repository state.
Summary by Sourcery
Improve podcast episode rendering, harden error handling in the generation API, and update setup checks for the RSS parsing dependency.
Bug Fixes:
Enhancements:
Build: