Skip to content

Breaking: EntityListFile changes to EntityListFiles - #28

Merged
digitalstraw merged 4 commits into
mainfrom
breaking-entity-list-files
Apr 24, 2026
Merged

digitalstraw merged 4 commits into
mainfrom
breaking-entity-list-files

Conversation

@digitalstraw

@digitalstraw digitalstraw commented Apr 24, 2026

Copy link
Copy Markdown
Owner

Input parameter can now receive multiple files listing entities instead of one.

Copilot AI review requested due to automatic review settings April 24, 2026 07:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a breaking configuration change for the analyzer: replacing the single entityListFile input with plural entityListFiles to support specifying multiple entity list files, and updates tests/docs accordingly.

Changes:

  • Rename config/CLI flag from entityListFile to entityListFiles and switch internal state from a single string to a slice of paths.
  • Update analyzer initialization to load and union protected entities across multiple files.
  • Update tests and README to reflect the new multi-file configuration and CLI usage.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
pkg/analyzer/analyzer.go Implements entityListFiles parsing from config/CLI and unions entity lists across files.
pkg/analyzer/analyzer_test.go Updates tests for the new config key and adds a multi-file test case.
README.md Documents the new YAML/CLI configuration for multiple entity list files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/analyzer/analyzer_test.go
Comment thread pkg/analyzer/analyzer.go
Comment thread pkg/analyzer/analyzer.go

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the analyzer configuration to accept multiple “entity list” files instead of a single file, and updates tests/documentation accordingly.

Changes:

  • Rename config/flag from entityListFile to entityListFiles and switch parsing to a multi-file list.
  • Update analyzer initialization and map-building logic to union protected structs across multiple files.
  • Expand test coverage and update README examples/CLI documentation for the new parameter.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pkg/analyzer/analyzer.go Switches config/flag parsing to multi-file input and unions protected structs across files.
pkg/analyzer/analyzer_test.go Updates existing tests and adds new cases for multi-file input and config decoding ([]any).
README.md Documents the new entity-list-files YAML config and -entityListFiles CLI flag usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/analyzer/analyzer.go Outdated
Comment thread pkg/analyzer/analyzer.go
@digitalstraw
digitalstraw merged commit 99ca910 into main Apr 24, 2026
5 checks passed
@digitalstraw
digitalstraw deleted the breaking-entity-list-files branch April 24, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants