-
Notifications
You must be signed in to change notification settings - Fork 5
GRPC for Google write operations + compression #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: google-grpc-compatible
Are you sure you want to change the base?
GRPC for Google write operations + compression #4
Conversation
lib/gcr.rb
Outdated
| # Whether cassettes should be compressed to zz | ||
| # | ||
| # Returns a boolean | ||
| def compress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| def compress | |
| def compress? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied, thx
… API calls with different responses
danielmbarlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks TD. Just had a smal comment to make about a minor detail
lib/gcr/cassette.rb
Outdated
| raise GCR::NoRecording.new(["Unrecorded request :", | ||
| "called #{calls_count} #{(calls_count > 1) ? "times" : "time"}, (recorded #{interactions.size})", | ||
| req.class_name, | ||
| req.body] | ||
| .join("\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little difficult to read maybe we could extract some variables and improve the whitespace
|
@asux Hi ! I propose you these improvements that we have been testing for some months now, without major issues. |
|
Hi @tdutreui-solocal. I'm bit loose context about this GCR, since not use it in recent project. Generally, your code makes sense to me. |
GCR_RECORDenvvar so that you can override an existing cassette