feat: add wallpaper picker popup with script and hyprpaper support#5
Open
defliez wants to merge 1 commit intodiinki:mainfrom
Open
feat: add wallpaper picker popup with script and hyprpaper support#5defliez wants to merge 1 commit intodiinki:mainfrom
defliez wants to merge 1 commit intodiinki:mainfrom
Conversation
- Added WallpaperMenu.qml for browsing and selecting wallpapers from user-defined directory - Integrated wallpaper picker into taskbar (Bar.qml) with new button - Extended Config.qml and settings.json for defining wallpaper directory, current wallpaper, and optionally custom script - Default behavior: run user script if set, otherwise fallback to hyprpaper
|
To be fair, this (and the theme picker) belongs more to the settings window IMO |
|
OK, so there were a couple of issues with the popup:
So, my suggestion is to change WallpaperMenu.qml: 176,177c176
< printf 'preload = %s\n' "$wp" > "$cfg"
< printf 'wallpaper = ,%s\n' "$wp" >> "$cfg"
---
> printf 'wallpaper {\n monitor = \n path = %s\n}' "$wp" > "$cfg"
182c181
< startCmd(["/bin/bash", "-lc", sh, "qs", filePath]);
---
> startCmd(["/bin/sh", "-lc", sh, "qs", filePath]); // no such thing as a /bin/bash in nixos
188c187
< startCmd(["/bin/bash", sp, filePath]);
---
> startCmd(["/bin/sh", sp, filePath]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hacked together a wallpaper picker in the taskbar :)
Supports hyprpaper and user-defined scripts
Features
settings.wallpaperDirwallpaperScriptPathis set insettings.json, that script is usedhyprpaperwith a regenerated configImplementation
WallpaperMenu.qml(new popup)Bar.qmlwith a new taskbar buttonConfig.qmlandsettings.jsonwith:wallpaperDircurrentWallpaperwallpaperScriptPath