Skip to content

Do not use cpprandom module type for this very bespoke interface.#9

Merged
athas merged 1 commit intomainfrom
ndimlcg
May 1, 2026
Merged

Do not use cpprandom module type for this very bespoke interface.#9
athas merged 1 commit intomainfrom
ndimlcg

Conversation

@athas
Copy link
Copy Markdown
Member

@athas athas commented May 1, 2026

We had to make cpprandom much worse to use just to cater to this exotic need, which doesn't even implement the cpprandom interface correctly.

@athas athas requested a review from WilliamDue May 1, 2026 08:40
@WilliamDue
Copy link
Copy Markdown
Collaborator

WilliamDue commented May 1, 2026

I think it is related to the change in cpprandom but I am sure we did talk about how cpprandom used to expose an integral module was a bad choice. Also I think hashmaps no longer uses cpprandom generally because it could lead to incorrect usage if the key module used a wrong random number generator.

Copy link
Copy Markdown
Collaborator

@WilliamDue WilliamDue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@athas athas merged commit 4cc04b7 into main May 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants