Error when loading binary_compressed pcd file

[bearpaw]

Thanks for the great library! When I reload the binary_compressed PCD file, which is saved by pypcd from ros message, there is an error happening at https://github.com/dimatura/pypcd/blob/master/pypcd/pypcd.py#L683

I checked the code, and found out that when decoding the data at https://github.com/dimatura/pypcd/blob/master/pypcd/pypcd.py#L264 pc_data is created as a numpy array with shape (width, ). After decoding, len(pc_data) is also width instead number of points (width x height).

I am not sure whether this problem is caused by different python version. Actually, I tested on both python2.7 and python3.7 (with #9) and noticed the same error.

Any suggestions here?

[yinxiaochuan]

The metadata['width'] should be corrected with metadata['points'] in the parse_binary_compressed_pc_data function.

pypcd/pypcd/pypcd.py

Line 264 in 20b032b

pc_data = np.zeros(metadata['width'], dtype=dtype)

pypcd/pypcd/pypcd.py

Line 268 in 20b032b

bytes = dt.itemsize * metadata['width']

The following line can be deleted.

pypcd/pypcd/pypcd.py

Line 510 in 20b032b

new_metadata['width'] = pc1.width+pc2.width

[bearpaw]

Thanks @yinxiaochuan !