Skip to content

Fix some undefined behavior #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hvenev-insait wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix some undefined behavior #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9c4102
ApplyCircOp: Return value instead of reference-to-local
hvenev Nov 22, 2022
88a677d
ExtractOp: Preserve container during iteration
hvenev Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/QuantumSSAOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,8 @@ def ExtractOp : QuantumSSA_Op<"extract", [NoSideEffect]> {

// bounds checking (if possible)
if(this->const_idx()) {
for (auto idxAttr : *this->const_idx()) {
auto idxs = *this->const_idx();
for (auto idxAttr : idxs) {
int64_t idx = idxAttr.dyn_cast<IntegerAttr>().getInt();
if (idx >= regsize)
return this->emitOpError() << "detected index value out of bounds, idx: "
Expand Down Expand Up @@ -997,7 +998,7 @@ def ApplyCircOp : QuantumSSA_Op<"apply"> {
}];

let extraClassDeclaration = [{
static TypeRange filterRegSize(TypeRange types, MLIRContext *ctx) {
static llvm::SmallVector<Type, 8> filterRegSize(TypeRange types, MLIRContext *ctx) {
Type rstate = RstateType::get(ctx, llvm::None);
llvm::SmallVector<Type, 8> filteredTypes;
filteredTypes.reserve(types.size());
Expand Down