Scene package cooking pipeline#2544
Draft
Nabla7 wants to merge 10 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## pim/feat/runtime-scene-loading #2544 +/- ##
==================================================================
- Coverage 70.71% 70.10% -0.62%
==================================================================
Files 897 886 -11
Lines 80362 80366 +4
Branches 7255 7309 +54
==================================================================
- Hits 56827 56339 -488
- Misses 21671 22132 +461
- Partials 1864 1895 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 45 files with indirect coverage changes 🚀 New features to boost your workflow:
|
3514b0b to
fc150e3
Compare
…into tmp/scene-cooking-ff
…into tmp/scene-cooking-ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes N/A
Runtime code can load scene packages, but source assets still need a repeatable offline cooking path. The cooking path must not hardcode one browser GLB heuristic: Rerun needs conservative GLBs, while Babylon/PimSim can use a different extension and optimization profile.
Solution
dimos.experimental.pimsim.scenefor source normalization, inspection, sidecar loading, entity planning, browser artifacts, MuJoCo wrapper XML, entity collision hulls, and optional MuJoCo binaries.rerun,babylon, andgeneric.package.browser_visual_path("rerun")orpackage.browser_visual_path("babylon").dimos.simulation.scene_assets.glbso Rerun-specific sanitization is a target policy, not a hidden global cooking rule.scenedependency extra for cook-time packages. Blender and nativegltfpackremain external tools.docs/development/large_file_management.mdand./bin/lfs_push.How to Test
Inspect source geometry before authoring sidecars:
Cook the office package for Rerun:
Cook a Babylon/PimSim visual:
Checks run locally:
Earlier branch validation also covered focused scene-cooking tests for source assets, entity collision, and MuJoCo collision specs.
Contributor License Agreement