feat(transport): deferred TransportSpec + .spec() migration#2596
Draft
spomichter wants to merge 1 commit into
Draft
feat(transport): deferred TransportSpec + .spec() migration#2596spomichter wants to merge 1 commit into
spomichter wants to merge 1 commit into
Conversation
Add TransportSpec dataclass for deferred transport construction in blueprints. Transports are now declared via Cls.spec(...) so nothing is instantiated at blueprint-definition time — the coordinator materializes specs at build time once CLI/env/config overrides resolve. Changes: - blueprints.py: TransportSpec, transport_config_name(), Blueprint type updates, dynamic transport config model generation - module_coordinator.py: _materialize_transports(), updated _connect_streams() to accept pre-built transports - stream.py: Transport._config_cls class-level default (None) - transport.py: PubSubTransport.spec() classmethod - All blueprint files: LCMTransport(...) -> LCMTransport.spec(...) and ROSTransport(...) -> ROSTransport.spec(...) Co-authored-by: Sam Bull <git@sambull.org>
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts and rebases Sam's transport config work (#2499) onto current
main.Adds
TransportSpecdataclass for deferred transport construction in blueprints. Transports are now declared viaCls.spec(...)so nothing is instantiated at blueprint-definition time — the coordinator materializes specs at build time once CLI/env/config overrides resolve.Changes
Infrastructure:
blueprints.py:TransportSpec,transport_config_name(),Blueprinttype updates, dynamic transport config model generationmodule_coordinator.py:_materialize_transports(), updated_connect_streams()to accept pre-built transportsstream.py:Transport._config_clsclass-level default (None)transport.py:PubSubTransport.spec()classmethodMechanical migration:
LCMTransport(...)→LCMTransport.spec(...)ROSTransport(...)→ROSTransport.spec(...)Context
This is a prerequisite for the WebRTC transport PR (#2048). The WebRTC transport will layer on top of this once merged.
Co-authored-by: Sam Bull git@sambull.org