Skip to content

test: remove flaky skipped test_basic_deployment #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spomichter merged 1 commit into from
Jun 26, 2026
+0 −34
Merged

test: remove flaky skipped test_basic_deployment #2630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions dimos/core/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@

import time

import pytest
from reactivex.disposable import Disposable

from dimos.core.core import rpc
from dimos.core.module import Module
from dimos.core.stream import In, Out
from dimos.core.testing import MockRobotClient
from dimos.core.transport import LCMTransport, pLCMTransport
from dimos.msgs.geometry_msgs.Vector3 import Vector3
from dimos.msgs.sensor_msgs.PointCloud2 import PointCloud2
from dimos.robot.unitree.type.odometry import Odometry
Expand Down Expand Up @@ -90,34 +87,3 @@ def test_classmethods() -> None:
assert hasattr(class_rpcs["start"], "__rpc__"), "start should have __rpc__ attribute"

nav._close_module()


@pytest.mark.skipif_in_ci
def test_basic_deployment(dimos) -> None:
robot = dimos.deploy(MockRobotClient)

print("\n")
print("lidar stream", robot.lidar)
print("odom stream", robot.odometry)

nav = dimos.deploy(Navigation)

# this one encodes proper LCM messages
robot.lidar.transport = LCMTransport("/lidar", PointCloud2)

# odometry & mov using just a pickle over LCM
robot.odometry.transport = pLCMTransport("/odom")
nav.mov.transport = pLCMTransport("/mov")

nav.lidar.connect(robot.lidar)
nav.odometry.connect(robot.odometry)
robot.mov.connect(nav.mov)

robot.start()
nav.start()

time.sleep(1)

assert robot.mov_msg_count >= 8
assert nav.odom_msg_count >= 8
assert nav.lidar_msg_count >= 8
Loading