test: skip test_security_module when ALIBABA_API_KEY is unset#2633
Merged
spomichter merged 2 commits intoJun 26, 2026
Conversation
Contributor
spomichter
approved these changes
Jun 26, 2026
paul-nechifor
approved these changes
Jun 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## release/0.0.13 #2633 +/- ##
=================================================
Coverage ? 71.01%
=================================================
Files ? 892
Lines ? 79238
Branches ? 7081
=================================================
Hits ? 56268
Misses ? 21130
Partials ? 1840
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
@pytest.mark.skipif_no_alibabatotest_security_module.Why
The test reaches a person-follow path that calls Qwen VL (
ALIBABA_API_KEY),but it was only gated by
skipif_no_openai. On a machine withOPENAI_API_KEYbut no
ALIBABA_API_KEY, it ran and hung until the 360s timeout instead ofskipping. The
skipif_no_alibabamarker already exists in conftest; this justapplies it, mirroring the existing
skipif_no_openaigate.Test
ruff checkclean. WithALIBABA_API_KEYunset the test is skipped atcollection (
pytest_collection_modifyitems) instead of running; with the keyset it still runs.
Contributor License Agreement