remove: drop all CircleCI support#13
Merged
Merged
Conversation
Removes CircleCI from DING entirely: - internal/runctx/runctx.go: drop the CIRCLECI=true detection case; removes `circleci` from the package-doc runner list - internal/runctx/runctx_test.go: drop TestNew_DetectsCircleCI; remove CIRCLE_* env vars from clearCIEnv - docs/recipes/circleci.md: deleted - docs/recipes/index.md: drop CircleCI status row - mkdocs.yml: drop CircleCI nav entry - README.md: drop CircleCI from auto-detection runner table and the CI/CD recipes list - docs/configuration.md: drop CircleCI from "Platform-specific examples" pointer - docs/recipes/jenkins.md: drop "/ CircleCI" reference in a Tradeoffs bullet This is a breaking change for any existing user with rules that match `runner=circleci` or use CircleCI-derived run-context labels — those alerts will now report `runner=local` instead. Background: an attempted Tier-2 CircleCI orb hit unrecoverable CCI auth/onboarding friction for new GitHub orgs. Rather than ship a half-supported integration, removing CircleCI entirely until the DevOps story improves. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes CircleCI from DING entirely. No more recipe, no more runctx auto-detection, no more docs mentions.
Files changed: 8 files, +4 / -132 lines.
Breaking change
Existing users with rules that match `runner=circleci` or rely on CircleCI-derived run-context labels (`repo`, `branch`, `commit`, `job` from CIRCLE_* env) will see those alerts now report `runner=local` instead. This is a feature regression by design.
Background
An attempted Tier-2 CircleCI orb (`ding-labs/ding-circleci-orb`) hit unrecoverable CCI auth/onboarding friction for new GitHub orgs — webhook validation errors, CLI-vs-UI integration mismatches, namespace claim path broken. Rather than ship a half-supported integration, removing CircleCI entirely until the DevOps story improves.
Test plan
Post-merge
🤖 Generated with Claude Code