feat: enable request replay by default - #1384
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughReplay 的环境默认值改为启用。设置页面将该值传递给表单。表单在未保存显式值时使用环境默认值。相关类型说明、五种语言文案和测试已同步更新。 ChangesReplay 默认值
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@messages/zh-CN/settings/config.json`:
- Line 98: 统一 Replay 描述措辞：在 messages/zh-CN/settings/config.json
第98行，将“直接跟尾在途流”改为“直接加入在途流”并使用中文标点；在 messages/zh-TW/settings/config.json
第174行，将“直接跟尾在途串流”改为“直接加入進行中的串流”并使用中文标点。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c7b942f3-f4e7-43fa-8d48-96770a88f240
📒 Files selected for processing (11)
messages/en/settings/config.jsonmessages/ja/settings/config.jsonmessages/ru/settings/config.jsonmessages/zh-CN/settings/config.jsonmessages/zh-TW/settings/config.jsonsrc/app/[locale]/settings/config/_components/system-settings-form.tsxsrc/app/[locale]/settings/config/page.tsxsrc/lib/config/env.schema.tssrc/types/system-config.tstests/unit/lib/env-request-replay.test.tstests/unit/settings/system-settings-form-replay-cache-toggles.test.tsx
| }, | ||
| "replayEnabled": "请求 Replay", | ||
| "replayEnabledDesc": "缓存上游响应并复用上游连接:并发或断线重连的相同请求直接跟尾在途流,不再重复请求供应商。保存前跟随环境变量 ENABLE_REQUEST_REPLAY,默认关闭。", | ||
| "replayEnabledDesc": "缓存上游响应并复用上游连接:并发或断线重连的相同请求直接跟尾在途流,不再重复请求供应商。保存前跟随环境变量 ENABLE_REQUEST_REPLAY,默认开启。", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
统一中文 Replay 描述的措辞。
两种中文翻译都使用了“跟尾在途流/串流”。该表达不够自然，可能使用户无法明确理解请求会加入现有的 in-flight stream。
messages/zh-CN/settings/config.json#L98-L98：将“直接跟尾在途流”改为“直接加入在途流”，并使用中文标点。messages/zh-TW/settings/config.json#L174-L174：将“直接跟尾在途串流”改为“直接加入進行中的串流”，并使用中文标点。
📍 Affects 2 files
messages/zh-CN/settings/config.json#L98-L98(this comment)messages/zh-TW/settings/config.json#L174-L174
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@messages/zh-CN/settings/config.json` at line 98, 统一 Replay 描述措辞：在
messages/zh-CN/settings/config.json 第98行，将“直接跟尾在途流”改为“直接加入在途流”并使用中文标点；在
messages/zh-TW/settings/config.json 第174行，将“直接跟尾在途串流”改为“直接加入進行中的串流”并使用中文标点。
Contributor
🧪 测试结果
总体结果: ✅ 所有测试通过 |
ding113
marked this pull request as ready for review
August 2, 2026 06:55
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
github-project-automation
Bot
moved this from Backlog
to Done
in Claude Code Hub Roadmap
github-actions
Bot
added
size/M
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review Summary
No significant issues identified in this PR.
PR Size: M
- Lines changed: 62
- Files changed: 11
Review Coverage
- Logic and correctness - Clean
- Security (OWASP Top 10) - Clean
- Error handling - Clean
- Type safety - Clean
- Documentation accuracy - Clean
- Test coverage - Adequate
- Code clarity - Good
Automated review by Codex AI
Contributor
There was a problem hiding this comment.
Reviewed PR #1384 (feat: enable request replay by default) and submitted the GitHub review.
- Applied the
size/Mlabel based on62changed lines across11files. - Checked the diff from the required perspectives: logic/correctness, security, error handling, type safety, comments/docs, tests, and simplification.
- No inline comments were posted because no issue in the modified lines survived full-context validation at the required confidence threshold.
- Posted the summary review comment on the PR with that outcome.
- Local test reruns were not possible in this runner because
bunandnode_moduleswere unavailable, so the review relied on the diff, surrounding code, test additions, and existing PR CI signals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_REQUEST_REPLAYis unset.falseoverrides and untouchednullsaves intact.Validation
bunx vitest run tests/unit/lib/env-request-replay.test.ts tests/unit/settings/system-settings-form-replay-cache-toggles.test.tsx --configLoader bundlebun run lint:fixbun run lintbun run typecheckbun run test(845files passed,2skipped;8211tests passed,13skipped)bun run build/zh-CN/settings/config: Request Replay renders enabled with a null persisted override and the enabled env default.No database schema or migration changes are required because
replay_enabledremains nullable andNULLcontinues to follow the environment default.Greptile Summary
The PR enables request replay when
ENABLE_REQUEST_REPLAYis unset while preserving explicit environment and persisted overrides.nullvalues and explicit boolean selections during saves.Confidence Score: 5/5
The PR appears safe to merge with no actionable correctness or security defects identified.
The backend default, runtime fallback, displayed switch state, and persisted tri-state semantics remain aligned, while replay attachment stays scoped by authenticated API-key identity.
Important Files Changed
Reviews (1): Last reviewed commit: "feat: enable request replay by default" | Re-trigger Greptile
Context used: