fix(gateway): keep tool errors from poisoning upstream health - #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CallToolResultresponses as connection-health successes even whenis_error=trueserver/discoverreturns JSON-RPC method-not-found (-32601)ProtectHomeVerification
cargo fmt --all --checkgit diff --checkUnifi::unifi; its safehealthaction returnsmeta.rc=okinvalid_paramresult leaves runtime connected with no last errorRuntime hardening
Production systemd now uses
Restart=alwayswith a 3-second delay. A controlled SIGTERM test changed the main PID and returned/readysuccessfully. Explicitsystemctl stopremains authoritative.