Skip to content

perf: make sure the output cols is keep in order #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pingdai wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf: make sure the output cols is keep in order #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f33fe4
perf: make sure the output cols is keep in order
Jun 7, 2022
2007ddc
Merge branch 'master' of github.com:pingdai/ormc
Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/model/table_model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,16 @@ func (tm *TableModel) renderTableDefine(r *Renderer) {
td.TableName = tm.table.TableName
td.TableStructName = tm.table.StructName()

// make sure the output cols is keep in order
cols := make([]*dbinfo.Column, 0, len(tm.table.Cols))
for _, col := range tm.table.Cols {
cols = append(cols, col)
}
sort.Slice(cols, func(i, j int) bool {
return cols[i].ColumnName < cols[j].ColumnName
})

for _, col := range cols {
cd := new(colDefine)
cd.ColName = col.ColumnName
cd.ColStructName = col.StructName()
Expand Down