Conversation
2791df5 to
ed815eb
Compare
ed815eb to
cb2eaac
Compare
Build Performance
Measured with hyperfine. Times show median ±stddev. |
LK
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io()is declared but never connected to any realized portsNote
Medium Risk
Adds a new warning emitted during schematic conversion and threads span/call-stack metadata through module parameter tracking, which may change diagnostic output and snapshots across builds.
Overview
Adds a new
module.io.unusedwarning when a moduleio()value (including interfaces) is ultimately not connected to any realized ports in that module, while avoiding false positives for forwarded nets/partially-used interfaces.Plumbs
io()/config()declaration span + call stack intoParameterMetadataandDiagnostic(newwith_call_stack) to produce richer, correctly-attributed warnings, and updates tests/snapshots accordingly.Fixes stdlib variant APIs by making
Crystal.GNDandMountingHole.P1only exist for the relevant package/plating variants, updating downstream tests that previously passed now-nonexistent ports, and documents the changes inCHANGELOG.md.Written by Cursor Bugbot for commit cb2eaac. This will update automatically on new commits. Configure here.