feat: add operation context to all error handlers#121
Open
zjpiazza wants to merge 1 commit into
Open
Conversation
Enhances error handling by adding operation context to all catchError
calls in extract and load modules. This provides better debugging
information when errors occur.
Changes:
- Added {context: {operation: 'function_name'}, fatal: true} to all
catchError calls in extract-*.ts and load-*.ts files
- Individual file errors (e.g., file downloads) use fatal: false to
allow batch operations to continue
This enables better error tracking and debugging in production by
identifying exactly which operation failed.
zjpiazza
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (5)
src/lib/load/load-users.ts:1
- The indentation is inconsistent. The context object should be aligned with the opening brace of catchError's second argument.
src/lib/load/load-translations.ts:1 - The indentation is inconsistent. The context object should be aligned with the opening brace of catchError's second argument.
src/lib/load/load-settings.ts:1 - The indentation is inconsistent. The context object should be aligned with the opening brace of catchError's second argument.
src/lib/load/load-roles.ts:1 - The indentation is inconsistent. The context object should be aligned with the opening brace of catchError's second argument.
src/lib/load/load-roles.ts:1 - The indentation is inconsistent. The context object should be aligned with the opening brace of catchError's second argument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances error handling by adding operation context to all catchError calls in extract and load modules. This provides better debugging information when errors occur.
Changes:
This enables better error tracking and debugging in production by identifying exactly which operation failed. I was regularly having issues when extracting or applying templates and it wasn't immediately obvious where the failure was occurring.