Skip to content

Respect explicit init boolean flags#135

Merged
bryantgillespie merged 1 commit into
mainfrom
bryantgillespie/review-issue-107
Jun 3, 2026
Merged

Respect explicit init boolean flags#135
bryantgillespie merged 1 commit into
mainfrom
bryantgillespie/review-issue-107

Conversation

@bryantgillespie

@bryantgillespie bryantgillespie commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Skip install dependency and git init prompts when the user explicitly passes the boolean flags or their aliases.
  • Extract init prompt helpers so the command file lints cleanly.

Verification

  • pnpm exec eslint src/commands/init.ts
  • pnpm run build

Closes #107

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Skips the interactive prompts for installing dependencies and initializing git when the user explicitly passes those boolean flags (or their negated forms) on the command line, and refactors the interactive flow into smaller helpers so the file passes lint.

Changes:

  • Adds hasBooleanFlag to detect explicit boolean flag presence in argv and uses it to bypass the install-deps/git-init confirms.
  • Extracts confirmBooleanFlag, confirmOverwriteDirectory, promptForTargetDirectory, and promptForValidTemplate helpers from runInteractive.
  • Tightens types (select<string>, TemplateInfo) and replaces .find with .some in the frontend validity check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands/init.ts Outdated
Comment thread src/commands/init.ts Outdated
Comment thread src/commands/init.ts Outdated
@bryantgillespie bryantgillespie force-pushed the bryantgillespie/review-issue-107 branch from edf608b to ae95b60 Compare May 13, 2026 21:02

@LZylstra LZylstra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantgillespie bryantgillespie merged commit 85dfe33 into main Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignores --gitInit and --installDeps?

3 participants