Skip to content

Address Completion Interface: Include the placeId in the emitted properties#309

Merged
bryantgillespie merged 5 commits into
directus-labs:mainfrom
tobyaherbert:main
Mar 10, 2026
Merged

Address Completion Interface: Include the placeId in the emitted properties#309
bryantgillespie merged 5 commits into
directus-labs:mainfrom
tobyaherbert:main

Conversation

@tobyaherbert

Copy link
Copy Markdown
Contributor

This PR updates the Address Completion Interface extension to include the placeId field in the emitted properties, allowing it to be retrieved from the database later. See #304 for more details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the placeId field to the emitted GeoJSON properties payload of the Address Completion Interface extension, enabling consumers (e.g., frontend applications) to retrieve the Google Place ID from the stored data for use cases like Google Maps embeds.

Changes:

  • placeId is added to the GeoProperties TypeScript interface.
  • placeId is included in the emitted properties object when a place is selected.
  • The PR author is added to contributors.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/address-completion-interface/src/interface.vue Adds placeId to the GeoProperties interface and includes it in the emitted properties payload when a place is selected.
contributors.yml Adds tobyaherbert as a contributor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/address-completion-interface/src/interface.vue
Comment thread packages/address-completion-interface/src/interface.vue Outdated
@bryantgillespie bryantgillespie requested a review from Copilot March 9, 2026 22:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bryantgillespie bryantgillespie self-requested a review March 10, 2026 15:51
@bryantgillespie

Copy link
Copy Markdown
Contributor

@tobyaherbert Can you bump the package version for this? Patch release is fine.

@tobyaherbert

Copy link
Copy Markdown
Contributor Author

@bryantgillespie Of course, I've bumped the extension's version to 1.0.2

@bryantgillespie bryantgillespie self-requested a review March 10, 2026 19:22
@bryantgillespie bryantgillespie merged commit c9e0a78 into directus-labs:main Mar 10, 2026
4 checks passed
@bryantgillespie

Copy link
Copy Markdown
Contributor

Published

@MarkBurvs

Copy link
Copy Markdown

Really useful update. Thank you @tobyaherbert

@tobyaherbert

Copy link
Copy Markdown
Contributor Author

@MarkBurvs - Glad it's useful for someone else too :)

@bryantgillespie - Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants