Address Completion Interface: Include the placeId in the emitted properties#309
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the placeId field to the emitted GeoJSON properties payload of the Address Completion Interface extension, enabling consumers (e.g., frontend applications) to retrieve the Google Place ID from the stored data for use cases like Google Maps embeds.
Changes:
placeIdis added to theGeoPropertiesTypeScript interface.placeIdis included in the emittedpropertiesobject when a place is selected.- The PR author is added to
contributors.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/address-completion-interface/src/interface.vue |
Adds placeId to the GeoProperties interface and includes it in the emitted properties payload when a place is selected. |
contributors.yml |
Adds tobyaherbert as a contributor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@tobyaherbert Can you bump the package version for this? Patch release is fine. |
|
@bryantgillespie Of course, I've bumped the extension's version to 1.0.2 |
|
Published |
|
Really useful update. Thank you @tobyaherbert |
|
@MarkBurvs - Glad it's useful for someone else too :) @bryantgillespie - Thanks! |
This PR updates the Address Completion Interface extension to include the
placeIdfield in the emitted properties, allowing it to be retrieved from the database later. See #304 for more details.