Repository navigation
Conversation
`Check & Lint` fails on every PR because the workflow floats to `@stable`, which is now clippy 1.99, where `double_must_use` fires on four async traits in pawan-core: agent/backend/mod.rs:18 agent/pool.rs:44 coordinator/mod.rs:444 tools/mod.rs:42 The lint is generated by `#[async_trait]`: 0.1.89's expansion emits a `#[must_use]` attribute with no message on a function already returning a `#[must_use]` type. It is a false positive in the macro, not a defect in these traits, so it is fixed at the source rather than suppressed. 0.1.92 does not emit it. Measured: clippy 1.99, workspace, --all-targets -D warnings 0 errors clippy 1.98, workspace, --all-targets -D warnings 0 errors Chose the bump over `#[allow(clippy::double_must_use)]` on four sites: the allow would have to be re-justified as the lint evolves, and would hide the diagnostic if it ever fires for a real reason. The bump also picks up the macro's own fixes. `syn` moves 2.0.117 -> 3.0.6 as a new transitive; async-trait 0.1.90 is yanked, 0.1.92 is current. Unblocks #109 and #105, both currently BLOCKED on this required check.
Member
Author
|
Superseded by #94 — closing to keep one canonical copy. I opened this before checking the queue. #87, #92, #94 and this all carry the Continuing on #94 ( The one thing this PR measured that the others did not is the differential Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR is BLOCKED on this check — including #109 and #105
Check & Lintfails on@stable(now clippy 1.99) withdouble_must_useon four async traits inpawan-core:main's last green CI wasde893a97at 2026-10-05 13:03, before stable moved. So this is not anyone's diff — it is toolchain drift that started failing every PR at once, and #109 and #105 are bothMERGEABLE/BLOCKEDon it.The lint is generated, not written
The four sites carry no
#[must_use].#[async_trait]0.1.89's expansion emits one with no message on a function already returning a#[must_use]type. It is a false positive in the macro, so I fixed it at the source instead of suppressing it.Fix: bump async-trait 0.1.89 → 0.1.92
Both toolchains green, so this does not trade one drift for another.
Why the bump and not
#[allow(clippy::double_must_use)]on four sites: the allow would need re-justifying as the lint evolves and would hide the diagnostic if it ever fires for a real reason. The bump also picks up the macro's own fixes.synmoves 2.0.117 → 3.0.6 as a new transitive;async-trait0.1.90 is yanked, 0.1.92 is current.Scope
Cargo.lockonly — 14 insertions, 3 deletions. No source changes.Landing this should clear the required check for every open PR. #109 carries the actual #108 fix; this is the gate in front of it.