Repository navigation
Conversation
|
Correction from the lane that opened #84: CI does run on Relevant here only because it changes one thing in my earlier comment on this PR: I said "main is unmeasured" and treated that as worse than red. It is neither — main was audited green on 2026-06-14 and has not changed since, so the baseline this PR diffs against is the baseline CI approved. The red gates on #82 remain exactly as established: |
|
Subsumed by a single verified lockfile, posted on #83. This PR's CI cannot go green on its own: |
6635ac4 to
a9a9c29
Compare
async-trait 0.1.89 (src/expand.rs:69) pushes a bare #[must_use] onto every generated async-trait fn. Those fns return Pin<Box<dyn Future>>, which is itself #[must_use], so clippy 1.99.0's new double_must_use lint fires and -D warnings turns it into an error. 0.1.92 removes that push. Lockfile-only: the declared range is already "0.1", so no Cargo.toml change. Verified on origin/main @ 46b8118 with clippy 1.99.0 (ci.yml:36 flags): async-trait 0.1.89 -> cargo clippy --workspace --exclude eruka-web -- -D warnings exit=101, 4 sites async-trait 0.1.92 -> same command exit=0, 0 sites Fixes #86. Unblocks #82 (RUSTSEC-2026-0285).
a9a9c29 to
520c03f
Compare
…ly bump This clears eleven of the fourteen findings `cargo audit` reports with the repository's suppressions applied (twelve of twenty-one without them), across twelve distinct advisories: quinn-proto 0.11.15 -> 0.11.18 RUSTSEC-2026-0338/0339/0340/0341/0342 rustls 0.23.39 -> 0.23.46 RUSTSEC-2026-0285/0346/0348/0349 rustls-webpki 0.103.13 -> 0.103.16 RUSTSEC-2026-0382 webpki-root-certs 1.0.7 -> 1.0.10 RUSTSEC-2026-0383 webpki-roots 1.0.7 -> 1.0.10 RUSTSEC-2026-0381 Each row lists the advisories that stop matching that copy. RUSTSEC-2026-0346 and RUSTSEC-2026-0349 also match the legacy `rustls 0.22.4` copy, which is not moved here. `aws-lc-rs` and `aws-lc-sys` move with `rustls 0.23.46`; they are forced by that move, not incidental drift. cargo audit on the resulting lockfile reports 3 findings, down from 14 with the repository's suppressions applied and 9 instead of 21 without them. The remaining three are the legacy `rustls 0.22.4` and `rustls-webpki 0.102.8` copies. Their dependency requires `rustls ^0.22` and that series has no patched release, so they are reported rather than suppressed: both are reachable from the CLI, and suppressing a reachable advisory would hide it. RUSTSEC-2026-0285 is removed from .cargo/audit.toml. The reason recorded for it described the copy as pinned below the patched floor; the resolver moves that copy to 0.23.46 inside its own range, and with the bump applied the advisory matches no locked copy.
520c03f to
317be4c
Compare
|
This branch was rebased onto current The branch held 553 commits, 45 of them after the merge-base with The replacement commit carries the measured bump set rather than a single
Two corrections are visible in this branch's history, both made before the diff was final: the |
What
A lockfile-only bump that moves five crates to the newest version their declared semver
ranges already allow.
quinn-protorustlsrustls-webpkiwebpki-root-certswebpki-rootsaws-lc-rsandaws-lc-sysmove withrustls 0.23.46; they are forced by that move, notincidental drift.
Measured effect
cargo auditon the lockfile before and after:The audit gate still reports three findings
They are the legacy
rustls 0.22.4andrustls-webpki 0.102.8copies: their dependencyrequires
rustls ^0.22, and that series has no release at or above the patched floor, so noin-repo bump clears them. Both are reachable from the CLI, so they are reported rather than
suppressed - a suppression entry would hide a reachable advisory. Tracked in #153.
h2 0.3.27(RUSTSEC-2026-0258) sits on the same line and stays suppressed for the samereason.
RUSTSEC-2026-0285 leaves the suppression list
.cargo/audit.tomlcarried RUSTSEC-2026-0285 with the reason "externally blocked ... pinsrustls below the patched floor". The resolver moves that copy to 0.23.46 inside its own
range, so the reason did not describe what the resolver does. With the bump applied the
advisory matches no locked copy, so the entry is removed instead of being left to suppress
nothing.
Fixes #77
Fixes #143
Fixes #144
Fixes #145
Fixes #146
Fixes #147
Fixes #150
RUSTSEC-2026-0346 and RUSTSEC-2026-0349 are only partly addressed: their
0.23copy isfixed here, their legacy
0.22.4copy is not, so #148, #149, #151 and #152 stay open.