Repository navigation
Keep the token out of stack traces and debug output - #35
Merged
Merged
Conversation
Mark the Http constructor's token #[\SensitiveParameter] (on its own line so PHP 7.4 still parses it as a comment) and mask it in a new __debugInfo(), which var_dump() and Xdebug use for object dumps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2SZobw97KdXvRTs54z
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Httpconstructor's$tokenas#[\SensitiveParameter]. The attribute sits on its own line, so PHP 7.4 still reads it as a comment.Http::__debugInfo(), which masks the token invar_dump(),print_r()and Xdebug object dumps.HttpTest. The Discord suite passes locally (33 tests).A DiscordPHP crash had printed the bot token in an Xdebug call stack. The main fix is in discord-php/DiscordPHP on the same branch.
Generated by Claude Code