Refine Crop transform documentation and enhance CI workflows#104
Conversation
… use environment variable for commit message
add GitHub Actions workflow for automatic code formatting with Black
📝 WalkthroughWalkthroughThis PR adds automated code formatting via GitHub Actions, updates documentation to reflect the package name change from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/continuous-testing.yml (1)
7-10: Note:"*.md"only ignores root-level markdown files.The pattern
"*.md"won't match markdown files in subdirectories (e.g.,docs/installation.md). If the intent is to ignore all markdown files, use"**/*.md"instead. If this is intentional to still trigger on documentation changes, the current pattern is fine.Optional: Ignore all markdown files
paths-ignore: - - "*.md" + - "**/*.md"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/continuous-testing.yml around lines 7 - 10, The ignore pattern "*.md" only matches root-level markdown files; if you intend to ignore all markdown files across the repo, replace the pattern string "*.md" with "**/*.md" in the continuous-testing workflow so markdown files in subdirectories (e.g., docs/installation.md) are also excluded; if you intentionally want to trigger CI on doc changes, leave the current "*.md" pattern as-is..github/workflows/auto-format.yml (1)
52-61: Consider adding[skip ci]to prevent potential workflow loops.While commits made by
github-actions[bot]typically don't trigger workflows, adding[skip ci]to the commit message provides an extra safeguard against infinite loops if that behavior ever changes.Optional: Add skip ci to commit message
run: | git config user.name "github-actions[bot]" git config user.email "github-actions[bot]@users.noreply.github.com" git add -A - git commit -m "formatted: $COMMIT_MSG" + git commit -m "formatted: $COMMIT_MSG [skip ci]" git push🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto-format.yml around lines 52 - 61, Update the "Commit formatted code" step to append "[skip ci]" to the commit message so CI isn't triggered by the bot commit; specifically change how COMMIT_MSG is used in the git commit invocation in that step (the env COMMIT_MSG and the run lines where git commit -m "formatted: $COMMIT_MSG" is executed) to include the suffix (for example "formatted: $COMMIT_MSG [skip ci]") before pushing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/auto-format.yml:
- Around line 52-61: Update the "Commit formatted code" step to append "[skip
ci]" to the commit message so CI isn't triggered by the bot commit; specifically
change how COMMIT_MSG is used in the git commit invocation in that step (the env
COMMIT_MSG and the run lines where git commit -m "formatted: $COMMIT_MSG" is
executed) to include the suffix (for example "formatted: $COMMIT_MSG [skip ci]")
before pushing.
In @.github/workflows/continuous-testing.yml:
- Around line 7-10: The ignore pattern "*.md" only matches root-level markdown
files; if you intend to ignore all markdown files across the repo, replace the
pattern string "*.md" with "**/*.md" in the continuous-testing workflow so
markdown files in subdirectories (e.g., docs/installation.md) are also excluded;
if you intentionally want to trigger CI on doc changes, leave the current "*.md"
pattern as-is.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 197445df-0395-4c9d-ac07-d33ea97e7c56
📒 Files selected for processing (7)
.github/workflows/auto-format.yml.github/workflows/continuous-testing.ymlREADME.mddocs/installation.mdminerva/transforms/transform.pytests/transforms/test_random_transforms.pytests/transforms/test_transform.py
Describe your changes
Changes:
Issue ticket number and link (If apply)
N/A
Checklist before requesting a review
Summary by CodeRabbit
New Features
Documentation
minerva(fromminerva-ml).Chores