refactor: Structure manipulation and SupercellConfigurationNode#2530
Merged
RobBuchananCompPhys merged 7 commits intoJun 24, 2026
Merged
Conversation
trisyoungs
reviewed
Jun 24, 2026
RobBuchananCompPhys
force-pushed
the
dissolve2/supercell-config-node-and-structure-manipulation
branch
from
96e04f8 to
b0e7299
Compare
trisyoungs
approved these changes
Jun 24, 2026
trisyoungs
left a comment
trisyoungs
left a comment
Member
There was a problem hiding this comment.
Looking really good - one significant comment made on the unit test though!
RobBuchananCompPhys
deleted the
dissolve2/supercell-config-node-and-structure-manipulation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.