chore: Mark missing serialisable data#2538
Open
trisyoungs wants to merge 2 commits into
Open
Conversation
trisyoungs
force-pushed
the
dissolve2/serialisable-node-data
branch
from
4a195fb to
975933d
Compare
trisyoungs
changed the base branch from
develop2
to
dissolve2/data-class-serialisation
trisyoungs
force-pushed
the
dissolve2/data-class-serialisation
branch
from
c58f9bd to
25fb13b
Compare
trisyoungs
force-pushed
the
dissolve2/serialisable-node-data
branch
from
975933d to
1ff1f68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies a fair number of nodes to include the necessary
addSerialisable()calls for their "restartable" data (i.e. that which was tagged withInRestartFilein Dissolve1). It will be in draft until #2537 is complete as it depends on the serialisers implemented therein. There are several outstanding "exotic" serialisers that need to be written in order to make the coverage 100%, but these are captured in a separate issue (#2539) to be addressed in the very near future.