perf: evaluate pool-backed order-book storage#96
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderBook::Storage::{Baseline,Pooled}andMatchingEngine(OrderBook::Storage)so M32 can compare baseline order-book storage against PMR-backed node allocation.Storage::Pooleduses a per-bookstd::pmr::unsynchronized_pool_resourcefor the order-bookstd::pmr::list,std::pmr::map, andstd::pmr::unordered_mapnodes.make bench-storage/qsl-bench storage/results/pool_backed_storage.txt.docs/pool_backed_storage.mdand ADR 0009 documenting the storage boundary, methodology, cache/locality implications, and limitations.Scope boundary
M32 uses PMR pool-backed node allocation. This is not direct M28
OrderPool<Capacity>integration.Direct
OrderPool<Capacity>integration would require an intrusive/custom-node order-book redesign because the currentstd::list<Order>allocates implementation-defined list nodes, not bareengine::Orderobjects. That future path is tracked separately in #95.Correctness evidence
The new invariant test proves
BaselineandPooledare semantically identical over generated flows:EngineSnapshotlast_seqBenchmark evidence
make bench-storagecompares baseline order-book/engine storage against pooled PMR order-book/engine storage. This is an engine-level workload, not isolated allocator-only acquire/release.The committed artifact was regenerated from source commit
f0055e2with:Dirty tree: no (excluding this generated output)The measured PMR result on this macOS/Apple-clang run is local hardware/compiler evidence only and is not a production-latency or general speedup claim.
Verification
make checkpassed, 188/188make asanpassed, 188/188make bench-storagepassed and wroteresults/pool_backed_storage.txtgit status --shortclean